On Tue, Dec 14, 2021 at 6:02 AM Josh Steadmon <steadmon@xxxxxxxxxx> wrote:
>
> On 2021.12.13 13:56, Junio C Hamano wrote:
> > Josh Steadmon <steadmon@xxxxxxxxxx> writes:
> >
> > > In po/README.md, we point core developers to gettext's "Preparing
> > > Strings" documentation for advice on marking strings for translation.
> > > However, this doc doesn't really discuss the issues around plural form
> > > translation, which can make it seem that nothing special needs to be
> > > done in this case.
> > >
> > > Add a specific callout here about marking plural-form strings so that
> > > the advice later on in the README is not overlooked.
> > >
> > > Signed-off-by: Josh Steadmon <steadmon@xxxxxxxxxx>
> > > ---
> > > po/README.md | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/po/README.md b/po/README.md
> > > index dcd8436c25..fd1e024dd3 100644
> > > --- a/po/README.md
> > > +++ b/po/README.md
> > > @@ -219,7 +219,10 @@ General advice:
> > > they're part of Git's API.
> > >
> > > - Adjust the strings so that they're easy to translate. Most of the
> > > - advice in `info '(gettext)Preparing Strings'` applies here.
> > > + advice in `info '(gettext)Preparing Strings'` applies here. Strings
> > > + referencing numbers of items may need to be split into singular and
> > > + plural forms; see the Q\_() wrapper in the C sub-section below for an
> > > + example.
Wouldn't it be better if we add a new rule ("Strings ... an example.")
after this one?
> > >
> > > - If something is unclear or ambiguous you can use a "TRANSLATORS"
> > > comment to tell the translators what to make of it. These will be
> >
> > Sounds good to me, but I'd want an ack by those from the l10n
> > department.
> >
> > Thanks.
>
> Hmm, I meant to CC both Jiang and Bagas, not sure why it didn't go
> through.
Yesterday I was interrupted by a meeting while reading this thread.
--
Jiang Xin
