Re: [PATCH 02/14] gitweb: make remote heads in heads list optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Giuseppe Bilotta" <giuseppe.bilotta@xxxxxxxxx> writes:

>> > This runs "git for-each-ref $others ''" which happens to be Ok
>> > for for-each-ref, but just to make sure other people do not
>> > emulate this and get bitten, I'd prefer to see it written like
>> > this:
>> >
>> > -               'refs/heads', 'refs/remotes'
>> > +               'refs/heads', ( $remote_heads ? 'refs/remotes' : ())
>>
>> Ah, of course.
>
> Uh, on second thoughts, considering this is actually replaced by much
> better code in patch 3/14, do I actually need to resend? :D

If we _already_ know that there is a breakage in an earlier
patch in the series before they are committed, I would really
prefer the committed history to be cleaned up.  There is no
point of recording "earlier mistakes".

I think resend or not is between you and Pasky, which would be a
different issue.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux