> > > + my ($remote_heads) = gitweb_check_feature('remote_heads');
> > > +
> > > open my $fd, '-|', git_cmd(), 'for-each-ref',
> > > ($limit ? '--count='.($limit+1) : ()), '--sort=-committerdate',
> > > '--format=%(objectname) %(refname) %(subject)%00%(committer)',
> > > - 'refs/heads', 'refs/remotes'
> > > + 'refs/heads', ( $remote_heads ? 'refs/remotes' : '')
> > > or return;
> >
> > This runs "git for-each-ref $others ''" which happens to be Ok
> > for for-each-ref, but just to make sure other people do not
> > emulate this and get bitten, I'd prefer to see it written like
> > this:
> >
> > - 'refs/heads', 'refs/remotes'
> > + 'refs/heads', ( $remote_heads ? 'refs/remotes' : ())
>
> Ah, of course.
Uh, on second thoughts, considering this is actually replaced by much
better code in patch 3/14, do I actually need to resend? :D
--
Giuseppe "Oblomov" Bilotta
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
