Re: [PATCH 13/14] gitweb: CSS style and refs mark for detached HEAD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/13/07, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> writes:
>
> > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> > index 4f7b7da..2c8a665 100755
> > --- a/gitweb/gitweb.perl
> > +++ b/gitweb/gitweb.perl
> > @@ -1690,7 +1690,7 @@ sub git_get_references {
> >       my %refs;
> >       if (git_is_head_detached()) {
> >               my $hash = git_get_head_hash($project);
> > -             $refs{$hash} = [ 'HEAD' ];
> > +             $refs{$hash} = [ 'detached/HEAD' ];
> >       }
> >       # 5dc01c595e6c6ec9ccda4f6f69c131c0dd945f8c refs/tags/v2.6.11
> >       # c39ae07f393806ccf406ef966e9a15afc43cc36a refs/tags/v2.6.11^{}
>
> Is this correct?  IOW is $refs{$hash} only used to give
> descriptive name given a 40-hexadecimal object name, and there
> is no requirement that you can give the descriptive name to
> rev-parse and get the object name back?

Ok, I admit it's a hack, but I've seen no other uses of the $refs
returned by git_get_references than being passed to format_ref_marker
which splits at the first / to see what to use as type and what to use
as name.

-- 
Giuseppe "Oblomov" Bilotta
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux