On Fri, Jul 23, 2021 at 09:21:11AM -0700, Junio C Hamano wrote: > > So modulo the commit message tweaks that Junio suggested, this all looks > > fine. I actually think my original "#error on too-old curl" is still > > reasonable. Yes, people whose distro has backported all of these > > features could possibly still use it. But in that case they likely know > > what's going on and can rip out the #error. It seems much more likely > > to me that it _won't_ work, and they'll get confused by obscure errors > > when they try to use an old curl. > > > > But I don't feel too stronlgy about it either way. > > Me neither. Those who are vanilla would not be helped by having it, > as their build would fail if their cURL is too old anyway even > without it. Those who backported would have a build that may or may > not work, but diagnosing it is part of the job of backporting their > cURL anyway. So in practice, I think "#error if you are older than > X" primarily would serve documentation purposes (which may be worth > doing, but requirements listed in INSTALL would probably be a better > alternative anyway). Yeah, it is purely for documentation to help people who are confused by a broken build. But I agree that INSTALL is probably reasonable there (not to mention that the whole point is that these versions are so old hardly anybody should be using them anyway). So let's forget about the #error thing, then. -Peff
