Jeff King <peff@xxxxxxxx> writes: >> That plan involves an "git rm -r compat/regex" and a compat/pcre >> instead, I have some long-left-over patches for that. > > OK. I was more worried about platforms where it was cumbersome to > install pcre. If we are shipping it as a vendored library, then at least > the dependency management is on us, and not the user. I do worry a > little about running into complications with building or debugging it. Please don't. I prefer not shipping compat/pcre ourselves; having to worry about version skew and picking up upstream security fixes in time, etc. for an external library that is well maintained is not what we need.