On Fri, Apr 09, 2021 at 09:44:57PM +0200, Ævar Arnfjörð Bjarmason wrote: > > I really like PCRE myself, but is it portable/common enough for us to > > start using it for baked-in funcname patterns? I sort of assumed there > > were exotic platforms where libpcre wouldn't build (or at least it would > > be inconvenient or uncommon to have it). And it would be nice to degrade > > those gracefully (or at least better than "I guess you don't get any > > builtin funcnames. Tough luck"). > > I think it's as portable as git, the JIT backend isn't, but PCRE itself > is portably C code, and e.g. everything that python, PHP and any other > number of things that depend on PCRE has had PCRE ported to it. > > That plan involves an "git rm -r compat/regex" and a compat/pcre > instead, I have some long-left-over patches for that. OK. I was more worried about platforms where it was cumbersome to install pcre. If we are shipping it as a vendored library, then at least the dependency management is on us, and not the user. I do worry a little about running into complications with building or debugging it. It would be importing a lot of new code (that in theory we never need to look at, but that is not always how it works...). And while it may build portably everywhere, that may involve extra work and not integrate with our build knobs (e.g., it looks like it uses autoconf) -Peff
