Jeff King <peff@xxxxxxxx> writes: >> struct object *lookup_object(struct repository *r, const struct object_id *oid) >> { >> unsigned int i, first; >> - struct object *obj; >> + struct object *obj = NULL; >> >> if (!r->parsed_objects->obj_hash) >> - return NULL; >> + return obj; > > I actually prefer the original style (where any "can we bail early" > checks just explicitly return NULL, rather than making you check to see > that obj is NULL). Perhaps I should return "me too" here.