On 4/5/2021 4:50 PM, Tom Saeger wrote: > On Mon, Apr 05, 2021 at 04:49:29PM -0400, Derrick Stolee wrote: >> On 4/5/2021 4:47 PM, Junio C Hamano wrote: >>> Tom Saeger <tom.saeger@xxxxxxxxxx> writes: >>> >>>> $ git config --local --get-regexp "pr-924" >>>> remote.pr-924.url https://github.com/gitgitgadget/git >>>> remote.pr-924.fetch +refs/tags/pr-924/derrickstolee/maintenance/refspec-v1 >>>> >>>> Seems legal, fetch even works >>> >>> Yes. For a ref that is one-shot use (like PR tags), this does not >>> make much sense, but >>> >>> [remote "submaintainer1"] >>> url = ... repository of submaintainer #1 ... >>> fetch = master >>> tagopts = --no-tags >>> >>> is a reasonable thing to have for those who regularly work with >>> submaintainer(s) of their project. They'd do >>> >>> $ git pull submaintainer1 >>> >>> to accept the work their submaintainers have done. >> >> Thanks for the extra testing! I'll be sure to fix this bug in v2. >> >> -Stolee >> > > Hacked this: > > @@ -920,6 +927,10 @@ static int fetch_remote(struct remote *remote, void *cbdata) > refspec_item_clear(&replace); > } > > + /* skip remote if no refspecs to fetch */ > + if (child.args.nr <= nargs) > + return 0; > + This is a good approach, but we'll need to clean up the data in 'child' since run_command() no longer does it for us. > return !!run_command(&child); Thanks, -Stolee
