On Thu, 11 Mar 2021 at 11:07, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
[...]
> > - To check if fixup_message that contains ':' is a commit
> > - reference for example: --fixup="HEAD^{/^area: string}" or
> > - a suboption of `--fixup`.
> > + fixup_message could be a commit reference for example:
> > + --fixup="HEAD^{/^area:string}" or a suboption of `--fixup`.
> > +
> > + As `amend` ...
>
> My suggestion primarily started a reaction to that "As `amend`..."
> which was not gramatically complete sentence, and I ended up
> rewriting everything after "As `amend`..."
>
Oops, I must have written a complete comment. I will take care of it.
> But re-reading what is in the paragraph before, I tend to think that
> it places too much stress on 'colon' and should be removed.
>
> The comment is about what is being parsed, so
>
> We limit --fixup's suboptions to only alpha characters. If
> the first character after a run of alpha is colon, then the
> part before the colon may be a known suboption name like
> `amend` or `reword`, or a misspelt suboption name. In
> either case, we treat it as --fixup=<suboption>:<arg>
>
> Otherwise, we are dealing with --fixup=<commit>.
>
> would be good. The code, when it decides it is not in the
> --fixup=<suboption>:<arg> form but it is --fixup=<commit>, does not
> even care about a colon, so there is no need to mention colon in the
> "Otherwise" part.
Okay, I will replace it.
Thanks for helping out and guiding.
Thanks and Regards,
Charvi
