On 3/9/2021 1:24 AM, Elijah Newren via GitGitGadget wrote: > This series (nearly) completes the merge-ort implementation, cleaning up > testsuite failures. The exceptions are some t6423 failures being addressed > independently[1]. I like that most of the patches here are small and straight-forward, and are backed up by tests. I'm concerned about the coupling of the "index with one entry" mechanism. I'd like to see that built differently by creating methods that can operate on an attributes file directly. If this method extraction is truly too difficult, then I'm willing to concede this point. It is worth some effort to try, though. Thanks, -Stolee
