On Thu, Mar 11, 2021 at 12:37 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > My suggestion primarily started a reaction to that "As `amend`..." > which was not gramatically complete sentence, and I ended up > rewriting everything after "As `amend`..." > > But re-reading what is in the paragraph before, I tend to think that > it places too much stress on 'colon' and should be removed. > > The comment is about what is being parsed, so > > We limit --fixup's suboptions to only alpha characters. If > the first character after a run of alpha is colon, then the > part before the colon may be a known suboption name like > `amend` or `reword`, or a misspelt suboption name. In > either case, we treat it as --fixup=<suboption>:<arg> > > Otherwise, we are dealing with --fixup=<commit>. I suggested a different way to rewrite this comment[1] in my review of patch [2/6] before I was aware that you two were discussing rewrites here in [3/6]. [1]: https://lore.kernel.org/git/CAPig+cRxZFV7DDtnYOxRqEYU4PwXK8gb2HSehDyGorqdgsmoNQ@xxxxxxxxxxxxxx/
