On 03.11.20 18:12, Junio C Hamano wrote: > Stefan Haller <lists@xxxxxxxxxxxxxxxx> writes: > >> Using stuff from oh-my-zsh is not an option for me. I'm not using >> oh-my-zsh, and I don't want to begin using it just for this one package. >> >> I could use Felipe's version from >> <https://github.com/felipec/git-completion> (and in fact, that's what >> I'm doing right now, for testing. Works great. :-) However, I'd have to >> remember to manually update it every so often. >> >> So yes, I prefer to use the one from git's distribution, because it is >> automatically kept up to date whenever I update git (as long as I >> symlink to it rather than copy it.) > > Thanks for another data point. > > You'd need to add to another "as long as", which is "as long as it > keeps up with felipec/git-completion". If we fall bahind, you'd be > better off getting updates directly from there, not from us. Yes, that's true of course. That's why I'm happy that Felipe contributes his version here, and that you are accepting it quickly. > And I suspect that not many Zsh users want to care about the > distinction between the two. If it were as easy to grab the latest > version of Felipe's as an update of Git from your distro, wouldn't > most people rather choose to do so? > > If we are not doing much reviews on Zsh completion on this list, due > to lack of interest and expertise, then we will either fall behind, > or blindly copy, Felipe's repository and republish as a small part > of our project, without adding much value ourselves. > > Which is not a very happy place for us to be in. I dunno. I still think it's valuable to do this. And I think the fact that it's in contrib makes it less likely that we fall behind, because you can just choose to merge updates without very thorough reviews (like with the current patch series), which you probably wouldn't feel comfortable doing if it had "graduated" out of contrib, as Felipe requests. -Stefan
