On 11/3/2020 2:23 PM, Jeff King wrote: > On Tue, Nov 03, 2020 at 08:55:52PM +0200, Sathyajith Bhat wrote: > >> I believe it is GitLens [1] which is causing the incorrect behaviour. >> I haven't had any crashes after I disabled GitLens, and that's the >> only extension I've had which interacts with scm. >> >> [1] https://github.com/eamodio/vscode-gitlens > > That makes sense. It seems pretty clear that its log__file() function > will produce this bogus combination. Despite having some indication that > it knows about the documentation forbidding it: > > https://github.com/eamodio/vscode-gitlens/blob/6cfd9fdedd7c6ec3bfa732af7c418bbbecdfba54/src/git/git.ts#L805 > > I don't know that project's code well enough to say whether there is a > higher-level bug there (the issue seems to be the "renames" flag being > enabled along with startLine; maybe the caller is wrong to specify > both). Thanks, both, for confirming the extension and the likely line of code causing this problem. I submitted an issue [1] on the GitLens repository. I'll continue watching it, but feel free to chime in yourself if you are interested. [1] https://github.com/eamodio/vscode-gitlens/issues/1139 Thanks, -Stolee
