Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: >> Have you fed your patches to those folks who have dozens of issues >> and the patches made their life better? > > Yes. That's good. >> (they will get >> their zsh/git completion from their distros---I am assuming that the >> distros get theirs from us in contrib/completion/). > > I don't know of anyone that relies on the zsh completion shared by > their distribution. Hmph. If the real users don't get the completion scripts from their distribution, is there still a point in having them in my tree? You are certainly not suggesting me to remove contrib/completion/ at least for zsh part, but then it is unclear what you want. Are you saying that by adding the latest and greatest, these real users who so far couldn't rely on distros now can start to do so, and we'll make their life easier by updating the 29-patch series (which I presume is the v2 of this 14-patch series)? In any case, some Zsh users, even though they are not active developers for the completion script, may have something good to say, now the 29-patch series has been posted to the list and queued. I didn't look at the zsh part, but I didn't find anything glaringly wrong in the changes to the bash completion. Thanks.