Hi Peff,
On Wed, 12 Aug 2020, Jeff King wrote:
> From my perspective as somebody who does not work on Windows, I wonder
> how much value there is in running vsbuild _and_ Windows CI for average
> developers. I have certainly gotten information from these jobs (e.g.,
> when introducing a portability problem, or missing a refactoring spot in
> Windows-only code). But I don't think I've ever gotten information from
> vsbuild that wasn't also in the regular windows build.
There have not been a _ton_ of these instances, but there have been a
couple:
2049b8dc65e (diffcore_rename(): use a stable sort, 2019-09-30)
Here, MSVC pointed out that `qsort()` does not need to be stable,
yet our test suite claimed that we expect it to be.
116d1fa6c69 (vreportf(): avoid relying on stdio buffering, 2019-10-30)
MSVC's code demonstrated that `fprintf()` prints out messages
character by character.
c097b95a260 (msvc: avoid using minus operator on unsigned types, 2019-10-04)
We relied on some iffy behavior of GNU C which allows negating
unsigned values (which cannot work if the high bit is set
already).
dbcd970c27b (push: do not pretend to return `int` from
`die_push_simple()`, 2019-09-30)
A non-void return type in a noreturn function is bogus.
fdda1ac62d7 (t0001 (mingw): do not expect a specific order of
stdout/stderr, 2019-06-19)
A test that might even have been flaky on Linux failed frequently
due to an incorrect assumption whether `stdout` would be flushed
before `stderr`.
I cannot find any more instances, so yes, I agree that the
`vs-build`/`vs-test` jobs might not be _all_ that necessary. So maybe we
should do something like this?
-- snipsnap --
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 30425404eb3..2549fff8edd 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -122,7 +122,7 @@ jobs:
path: ${{env.FAILED_TEST_ARTIFACTS}}
vs-build:
needs: ci-config
- if: needs.ci-config.outputs.enabled == 'yes'
+ if: (github.repository == 'git/git' || github.repository == 'gitgitgadget/git') && needs.ci-config.outputs.enabled == 'yes'
env:
MSYSTEM: MINGW64
NO_PERL: 1
