Jeff King <peff@xxxxxxxx> writes: > On Mon, Aug 03, 2020 at 10:35:40PM -0700, Junio C Hamano wrote: > >> * ss/cmake-build (2020-06-26) 8 commits >> (merged to 'next' on 2020-08-03 at a0d70165c1) >> + ci: modification of main.yml to use cmake for vs-build job >> + cmake: support for building git on windows with msvc and clang. >> + cmake: support for building git on windows with mingw >> + cmake: support for testing git when building out of the source tree >> + cmake: support for testing git with ctest >> + cmake: installation support for git >> + cmake: generate the shell/perl/python scripts and templates, translations >> + Introduce CMake support for configuring Git >> >> Originally merged to 'next' on 2020-08-01 >> >> CMake support to build with MSVC for Windows bypassing the Makefile. >> >> Will merge to 'master'. >> cf. https://github.com/git/git/runs/892824895 > > I ran into issues with this, as I have several in-progress topics (not > yet sent to the list) that touch our Makefile, and they needed updates > to the cmake file (because it reproduces a lot of the lists and logic > from the Makefile). > > The original philosophy behind putting it in contrib is that most people > wouldn't have to care, and folks interested in cmake would be > responsible for keeping it up to date. But the top patch makes it hard > to ignore, because the vs-build CI job will fail. > > I'm not sure of the right path forward. I was definitely unenthused to > be dealing with cmake, and the problem came up as soon as the series hit > next. My hope is that if we let vs-build broken long enough, those who want to see cmake to graduate would fix it. We can always threaten the topic to be discarded out of 'next' after the next release if it hasn't been fixed ;-)
