On Wed, Aug 12, 2020 at 09:26:05PM +0530, Sibi Siddharthan wrote: > The CMake script was not intended to be a write once and forget > situation, it tries to pull from the Makefile as much > as possible. A few changes are needed, which I intend to do. Yeah, I know. My main beef was that because it fails CI, the urgency of doing that fix gets pushed onto people working on their individual topics (in fact there is nothing for you to fix yet because I haven't even sent these topics upstream). I don't know how to solve that without stopping its use in the vsbuild CI job, though. And clearly we need _something_ to generate the build data for that job. So this may be the last bad thing. >From my perspective as somebody who does not work on Windows, I wonder how much value there is in running vsbuild _and_ Windows CI for average developers. I have certainly gotten information from these jobs (e.g., when introducing a portability problem, or missing a refactoring spot in Windows-only code). But I don't think I've ever gotten information from vsbuild that wasn't also in the regular windows build. -Peff
