Hi Junio, On Tue, Jul 07, 2020 at 03:11:33PM -0700, Junio C Hamano wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > It seems that the patch series lacks coverage for t9400 where we > > have > > > > test_expect_success 'cvs server does not run with vanilla git-shell' ' > > ( > > cd cvswork && > > CVS_SERVER=$WORKDIR/remote-cvs && > > export CVS_SERVER && > > test_must_fail cvs log merge > > ) > > ' > > > > which obviously needs to be converted before we declare that it is a > > hard error to feed a non-git command to test_must_fail. > > For today's integration cycle, I added a fix-up at the tip of the topic > > https://github.com/git/git/commit/dde09ce2b7dd62eafda6339c1c31ccfeb0f39cee Thanks. For the final version of this series, we should either queue your patch or the one I just sent[0] just after the patch for t7107 so that it comes before the we flip the switch on test_must_fail and also so that the patches show up in increasing numerical order. [0]: https://lore.kernel.org/git/4ca5e1f9c06ed509fc3165c550d0d665dd5b69c0.1594159495.git.liu.denton@xxxxxxxxx/
