Junio C Hamano <gitster@xxxxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >>> Changes since v1: >>> >>> * Add a code comment to force_color() >>> >>> * Do not allow nested env's in test_must_fail_acceptable() >>> >>> * Clean up the env-processing case code >>> >>> * Give an example on how to use `!`. >> >> Thanks for a resend. Now part #5 is in 'master', I can queue these >> directly on top. > > It seems that the patch series lacks coverage for t9400 where we > have > > test_expect_success 'cvs server does not run with vanilla git-shell' ' > ( > cd cvswork && > CVS_SERVER=$WORKDIR/remote-cvs && > export CVS_SERVER && > test_must_fail cvs log merge > ) > ' > > which obviously needs to be converted before we declare that it is a > hard error to feed a non-git command to test_must_fail. For today's integration cycle, I added a fix-up at the tip of the topic https://github.com/git/git/commit/dde09ce2b7dd62eafda6339c1c31ccfeb0f39cee