Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> writes: > Since this patch series has been merged with pu, I didn't know whether > I should wait till the patch gets merged into 'next' or do the change > immediately. Ah, OK. Being in 'pu' does not mean no more than that the patch was sent to the list and I happened to have seen it. If it were ready to be merged to 'next', I may have marked it as such in the "What's cooking" report, but otherwise, the default is to be polished until it gets ready. > One more thing, there is an issue with the scripts' permissions when > run in Linux. They don't have execute permissions. What script? Your scripts you add in the patch series? What is the reason why they lack execute permissions? Forgot to "chmod +x"? It sounds like, in addition to issues pointed out during the review cycle, you have identified more issues that can be solved to make the series more complete yourself, which is a very good thing. It is hard for anyone to review one's own patches and find issues, and you seem to be getting the hang of it. These are all good thing to address before the topic becomes ready for 'next'. And there is no need to hurry. If you do not want to waste time in repeated rewrite and review cycle, the best way may be to go slowly and carefully to avoid "this was known to be suboptimal even when I wrote it, but I didn't bother fixing it before sending it out, but it was noticed during the review so I have to update it and send a new round". Thanks.
