On Thu, Jun 18, 2020 at 10:13 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> writes: > > > On Mon, Jun 15, 2020 at 7:33 PM Øystein Walle <oystwa@xxxxxxxxx> wrote: > >> > >> > +if(WIN32) > >> > + set(EXE_EXTENSION .exe) > >> > +else() > >> > + set(EXE_EXTENSION) > >> > +endif() > >> > >> You can probably use CMAKE_EXECUTABLE_SUFFIX here. See: > >> https://cmake.org/cmake/help/latest/variable/CMAKE_EXECUTABLE_SUFFIX.html > >> > > > > Could have done it that way, will try to change it once the patch > > series gets merged with next or master. > > If it is something that makes the result even simpler than the above > quoted 5 lines, I do not see a reason to postpone it and use that > simpler way from the beginning. > Since this patch series has been merged with pu, I didn't know whether I should wait till the patch gets merged into 'next' or do the change immediately. If I do this change should I fixup the commit that introduced EXE_EXTENSION or commit on top of HEAD? Please tell. I will do the changes immediately and submit another PATCH series. One more thing, there is an issue with the scripts' permissions when run in Linux. They don't have execute permissions. Since the main focus of the CMake build is to help windows devs, should I defer this modification until a later time, or should I do them immediately. The changes will involve adding a line of code to each of the script varieties(sh,perl,python) so 3 more lines of extra code. Thank You, Sibi Siddharthan > Thanks.
