Re: [PATCH v4 6/8] cmake: support for building git on windows with mingw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> writes:

> On Mon, Jun 15, 2020 at 7:33 PM Øystein Walle <oystwa@xxxxxxxxx> wrote:
>>
>> > +if(WIN32)
>> > +     set(EXE_EXTENSION .exe)
>> > +else()
>> > +     set(EXE_EXTENSION)
>> > +endif()
>>
>> You can probably use CMAKE_EXECUTABLE_SUFFIX here. See:
>> https://cmake.org/cmake/help/latest/variable/CMAKE_EXECUTABLE_SUFFIX.html
>>
>
> Could have done it that way, will try to change it once the patch
> series gets merged with next or master.

If it is something that makes the result even simpler than the above
quoted 5 lines, I do not see a reason to postpone it and use that
simpler way from the beginning.

Thanks.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux