On Thu, Mar 26, 2020 at 4:28 AM Denton Liu <liu.denton@xxxxxxxxx> wrote: > In the 'did not use upload-pack service' test, we have a complicated > song-and-dance to ensure that there are no "/git-upload-pack" lines in > "$HTTPD_ROOT_PATH/access.log". Simplify this by just checking that grep > returns a non-zero exit code. > > Signed-off-by: Denton Liu <liu.denton@xxxxxxxxx> > --- > diff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh > @@ -248,9 +248,7 @@ test_expect_success 'fetch can handle previously-fetched .idx files' ' > test_expect_success 'did not use upload-pack service' ' > - test_might_fail grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log >act && > - : >exp && > - test_cmp exp act > + ! grep "/git-upload-pack" "$HTTPD_ROOT_PATH/access.log" > ' It would have been nice for the commit message to have mentioned that the change is also eliminating an incorrect application of test_might_fail(), but it's probably not worth a re-roll.
