On Thu, Mar 26, 2020 at 4:28 AM Denton Liu <liu.denton@xxxxxxxxx> wrote: > The expected references are generated using a here-doc with some inline > command substitutions. If one of the `git rev-parse` invocations within > the command substitutions fails, its return code is swallowed and we > won't know about it. Replace these command substitutions with > generate_references(), which actually reports when `git rev-parse` > fails. > > Signed-off-by: Denton Liu <liu.denton@xxxxxxxxx> > --- > diff --git a/t/t5512-ls-remote.sh b/t/t5512-ls-remote.sh > @@ -212,17 +217,18 @@ test_expect_success 'protocol v2 supports hiderefs' ' > test_expect_success 'ls-remote --symref' ' > + echo "$oid refs/remotes/origin/HEAD" >>expect && > + generate_references \ > + refs/remotes/origin/master \ > + refs/tags/mark \ > + refs/tags/mark1.1 \ > + refs/tags/mark1.10 \ > + refs/tags/mark1.2 >>expect && Botched indentation of the "refs/remotes/origin/master" line.