On Sun, Mar 22, 2020 at 09:44:39AM -0600, Taylor Blau wrote: > > Using QUICK means we won't waste time double-checking in the second > > case. But it means we won't catch the first case, and we may generate a > > new graph file that omits the object. They're both optimizations, and I > > don't think we're impacting correctness[1], but it's not clear to me > > whether one is a win over the other. We don't generally expect objects > > we have to go away often. > > > > Skipping fetching seems a little more straight-forward to me. If we had > > it in a graph file, presumably we had the actual object before, too. And > > either we're in the first case above (we really do have it and just need > > to double-check) in which case not saying QUICK would be enough. Or we > > intentionally got rid of it. In which case downloading it just to > > generate a cache is quite silly. > > I was going to write that I'm not entirely sure of this, but I tried to > talk myself through it below, and I think that the right flag is *only* > OBJECT_INFO_SKIP_FETCH_OBJECT. Re-reading what I wrote, I think I didn't say it very well. But yes, that's what I think we ought to do, too: only use SKIP_FETCH_OBJECT. -Peff
