On 3/21/2020 2:50 PM, Junio C Hamano wrote: > Do we need to worry about INFO_QUICK and SKIP_FETCH_OBJECT in this > codepath, by the way? I was coming back to this thread to bring up these exact flags for consideration. The good news is that in a partial clone with any amount of filtering we will still have all reachable commits, which are necessary for the commit-graph to make sense. The only ones that would fail has_object_file() are ones removed by GC, but they may still exist on the remote. So without SKIP_FETCH_OBJECT, we would generate a network call even if the server has GC'd to remove the commits. This gets particularly bad when the server returns all reachable objects from that commit! Thanks, -Stolee
