On 2/19/2020 4:17 PM, Junio C Hamano wrote:
> Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
>
>> On Wed, Feb 19, 2020 at 3:52 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>> "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>>>> +test_expect_failure 'verify fetch succeeds when asking for new tags' '
>>>> + git clone --filter=blob:none "file://$(pwd)/srv.bare" tag-test &&
>>>> + for i in I J K
>>>> + do
>>>> + test_commit -C src $i &&
>>>> + git -C src branch $i
>>>> + done &&
>>>> + git -C srv.bare fetch --tags origin +refs/heads/*:refs/heads/* &&
>>>> + git -C tag-test fetch --tags origin
>>>> +'
>>>
>>> Is this about an ultra-recent regresssion? When applied directly on
>>> top of v2.25.0, this one seems to pass already without any change.
>>
>> True, although both fail when applied atop "master".
>
> I flipped the first one (i.e. test #24) to expect success and run
> bisect between 3f7553ac ("Merge branch 'jt/t5616-robustify'",
> 2020-02-12) and the tip of 'master'.
>
> Interesting that bisecting it points at 684ceae3 ("fetch: default to
> protocol version 2", 2019-12-23).
Thanks for tracking this down. I had originally been working on
top of master, but then rebased onto v2.25.0 to test this on our
VFS for Git/Scalar fork [1]. I have since noticed that the test
passes in that case.
Thanks,
-Stolee
[1] https://github.com/microsoft/git/pull/247
