Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
> On Wed, Feb 19, 2020 at 3:52 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>> > +test_expect_failure 'verify fetch succeeds when asking for new tags' '
>> > + git clone --filter=blob:none "file://$(pwd)/srv.bare" tag-test &&
>> > + for i in I J K
>> > + do
>> > + test_commit -C src $i &&
>> > + git -C src branch $i
>> > + done &&
>> > + git -C srv.bare fetch --tags origin +refs/heads/*:refs/heads/* &&
>> > + git -C tag-test fetch --tags origin
>> > +'
>>
>> Is this about an ultra-recent regresssion? When applied directly on
>> top of v2.25.0, this one seems to pass already without any change.
>
> True, although both fail when applied atop "master".
I flipped the first one (i.e. test #24) to expect success and run
bisect between 3f7553ac ("Merge branch 'jt/t5616-robustify'",
2020-02-12) and the tip of 'master'.
Interesting that bisecting it points at 684ceae3 ("fetch: default to
protocol version 2", 2019-12-23).
diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh
index 9a9178fd28..099406c2f1 100755
--- a/t/t5616-partial-clone.sh
+++ b/t/t5616-partial-clone.sh
@@ -384,6 +384,32 @@ test_expect_success 'fetch lazy-fetches only to resolve deltas, protocol v2' '
grep "want $(cat hash)" trace
'
+test_expect_success 'verify fetch succeeds when asking for new tags' '
+ git clone --filter=blob:none "file://$(pwd)/srv.bare" tag-test &&
+ for i in I J K
+ do
+ test_commit -C src $i &&
+ git -C src branch $i
+ done &&
+ git -C srv.bare fetch --tags origin +refs/heads/*:refs/heads/* &&
+ git -C tag-test fetch --tags origin
+'
+
+test_expect_failure 'verify fetch downloads only one pack when updating refs' '
+ git clone --filter=blob:none "file://$(pwd)/srv.bare" pack-test &&
+ ls pack-test/.git/objects/pack/*pack >pack-list &&
+ test_line_count = 2 pack-list &&
+ for i in A B C
+ do
+ test_commit -C src $i &&
+ git -C src branch $i
+ done &&
+ git -C srv.bare fetch origin +refs/heads/*:refs/heads/* &&
+ git -C pack-test fetch origin &&
+ ls pack-test/.git/objects/pack/*pack >pack-list &&
+ test_line_count = 3 pack-list
+'
+
. "$TEST_DIRECTORY"/lib-httpd.sh
start_httpd
--
2.25.1-440-g39558b81cc
