Hi, > Subject: Re: [PATCH 3/3] git-gui: completed german translation Well, since I don't have much to say about the patch contents, I'll just comment on the commit message. "completed german translation" seems to suggest it was in some way incomplete before. My impression from reading the patch is that it is more glossary/word changes. Maybe change the subject to reflect that? On 24/01/20 10:33PM, Christian Stimming via GitGitGadget wrote: > From: Christian Stimming <christian@xxxxxxxxxxxx> > > More glossary changed, mostly adapted to git-core German glossary at > https://github.com/ruester/git-po-de/wiki/Translation-Guidelines > and translation changed accordingly. One notable change in translation > is branch -> Branch. Overall increased consistency. Same comment as the last patch: along with explaining _what_ the commit does, also explain _why_ the commit does it. Thanks for the patches. Will merge them once you send in a re-roll with the updated commit subjects and messages. PS: It would be nice if we can get an ACK from a German speaker. > Signed-off-by: Christian Stimming <christian@xxxxxxxxxxxx> -- Regards, Pratyush Yadav
