On Tue, Nov 12, 2019 at 12:44:58PM +0100, SZEDER Gábor wrote: > > > 1: 8a030f1796 ! 1: 02d21d4117 hex: drop sha1_to_hex() > > > @@ Commit message > > > hex: drop sha1_to_hex() > > > > > > There's only a single caller left of sha1_to_hex(), since everybody now > > > - uses oid_to_hex() instead. This case is in the sha1dc wrapper, where we > > > + uses hash_to_hex() instead. This case is in the sha1dc wrapper, where we > > > print a hex sha1 when we find a collision. This one will always be sha1, > > > - regardless of the current hash algorithm, so we can't use oid_to_hex() > > > + regardless of the current hash algorithm, so we can't use hash_to_hex() > > > here. In practice we'd probably not be running sha1 at all if it isn't > > > the current algorithm, but it's possible we might still occasionally > > > need to compute a sha1 in a post-sha256 world. > [...] > And because of this the updated "since everybody uses hash_to_hex()" > in the first hunk sounds a bit wrong, because barely anybody actually > uses hash_to_hex(). You're right, I should have read more carefully. -Peff
