On Mon, Nov 11, 2019 at 03:18:05PM +0100, SZEDER Gábor wrote: > On Mon, Nov 11, 2019 at 04:04:18AM -0500, Jeff King wrote: > > There's only a single caller left of sha1_to_hex(), since everybody now > > uses oid_to_hex() instead. This case is in the sha1dc wrapper, where we > > print a hex sha1 when we find a collision. This one will always be sha1, > > regardless of the current hash algorithm, so we can't use oid_to_hex() > > Nit: s/oid_to_hex/hash_to_hex/ > > We can't use oid_to_hex() because we don't have a 'struct object_id' > in the first place, as sha1dc only ever deals with 20 unsigned chars. Ah, you're right. I admit I am still getting up to speed on all of the new hash-agnostic versions of the various functions. -Peff
