On Mon, Aug 05, 2019 at 11:49:46AM -0700, Junio C Hamano wrote:
> Jeff King <peff@xxxxxxxx> writes:
>
> >> OPT_STRING('s', "source", &opts.from_treeish, "<tree-ish>",
> >> - N_("where the checkout from")),
> >> + N_("where the checkout is from")),
> >
> > I think your original "where to checkout from" is better.
>
> Would we even want to do s/where/which tree-ish/?
Yeah, I think that is even better.
> > prefix. For advise() we nicely pick out the newlines and prefix each
> > line individually, but warning(), error(), etc, don't do that. Maybe
> > they should.
>
> Yeah, I'd be surprised that nobody thought of doing that, so perhaps
> somebody tried and failed with a possible fallout. I do not offhand
> see any downside of teaching them to do the prefixing.
I know we've discussed it before, but a quick search of the archive only
came up with instances of me suggesting we should do it. ;)
Besides the obvious fallout you mentioned where callers might need to
drop their own custom indenting, it's possible people might be less
happy for output like:
warning: a thing happened to these paths:
foo
bar
where people might prefer not having a prefix on the subsequent lines,
because it makes it easier to cut-and-paste.
Anyway, that is all out of scope for this patch.
-Peff
