On Tue, Nov 13, 2018 at 7:42 PM Derrick Stolee <stolee@xxxxxxxxx> wrote: > > On 11/4/2018 6:44 PM, brian m. carlson wrote: > > +int hash_algo_by_name(const char *name) > > +{ > > + int i; > > + if (!name) > > + return GIT_HASH_UNKNOWN; > > + for (i = 1; i < GIT_HASH_NALGOS; i++) > > + if (!strcmp(name, hash_algos[i].name)) > > + return i; > > + return GIT_HASH_UNKNOWN; > > +} > > + > > Today's test coverage report [1] shows this method is not covered in the > test suite. Looking at 'pu', it doesn't have any callers. > > Do you have a work in progress series that will use this? Could we add a > test-tool to exercise this somehow? Going by the function name, it should be used when hash-object or other commands learn about --object-format=<name>. -- Duy