On 2018.11.13 12:12, Junio C Hamano wrote: > steadmon@xxxxxxxxxx writes: > > > OSS-Fuzz requires C++-specific flags to link fuzzers. Passing these in > > CFLAGS causes lots of build warnings. Using separate CXXFLAGS avoids > > this. > > We are not a C++ shop, so allow me to show ignorance about how > projects that are OSS-Fuzz-enabled work. Do they use one set of > CXXFLAGS when compiling the "real thing" and a separate set (perhaps > one is subset of the other, or perhaps these two just have overlap) > of CXXFLAGS when building to link with the fuzzer? > > What I am trying to get at is if this should be CXXFLAGS or > CXX_FUZZER_FLAGS. If the OSS-Fuzz-enabled C++ projects use one set > of flags for the "main" part of the project (to produce binaries to > be run by the end users) and then link with extra flags to work with > fuzzers, I would imagine that they won't call the latter CXXFLAGS > but call it something else, and we probably should follow suit if > that is the case. > > Not that we plan to (re)write the maint part of Git in C++ ever, so > I am personally OK with sacrificing the most generic CXXFLAGS macro > for the sole use of OSS-Fuzz linkage, but I'd prefer to leave the > door open so that other things like OSS-Fuzz that require C++ can be > added like your work does to the project. > > Thanks. OSS-Fuzz only provides one set of CXXFLAGS for use on both compiling project C++ project files as well linking the fuzzers themselves. So in the event that Git ever added any C++ sources, they would need to use the same set of CXXFLAGS. Given that, do you agree with Stefan that it is more intuitive to define CXXFLAGS next to the fuzzer build rules, since that's the only place it's used for now?
