On November 4, 2018 6:26 PM, Junio C Hamano, wrote: > Johannes Sixt <j6t@xxxxxxxx> writes: > > > Am 03.11.18 um 09:14 schrieb Carlo Arenas: > >> On Fri, Nov 2, 2018 at 9:44 AM Johannes Sixt <j6t@xxxxxxxx> wrote: > >>> > >>> + timeout = elapsed >= orig_timeout ? 0 : (int)(orig_timeout - > >>> + elapsed); > >> > >> nitpick: cast to DWORD instead of int > > > > No; timeout is of type int; after an explicit type cast we don't want > > to have another implicit conversion. > > > > -- Hannes > > OK, thanks. It seems that the relative silence after this message is a sign that > the resulting patch after squashing is what everybody is happey with? On my platform (HPE NonStop), DWORD is being defined as unsigned int (32-bit) rather than unsigned long long (64 bit). The definition comes through the odbc/windows.h include, not the compiler or any core definition. It's only a nano-quibble (if even that), because GetTickCount64 is not defined on the platform anyway, so this is probably not a big deal. Cheers, Randall
