Re: [GSoC][PATCH v8 17/20] stash: convert save to builtin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Eric,

On Mon, 3 Sep 2018, Eric Sunshine wrote:

> On Mon, Sep 3, 2018 at 2:44 PM Johannes Schindelin
> <Johannes.Schindelin@xxxxxx> wrote:
> > where `strbuf_join_argv()` would be implemented like this (and I would put
> > it into strbuf.c and strbuf.h:
> >
> >         const char *strbuf_join_argv(struct strbuf *buf,
> >                                      int argc, const char **argv, char delim)
> >         {
> >                 if (!argc)
> >                         return buf->buf;
> >
> >                 strbuf_addstr(buf, *argv);
> >                 while (--i) {
> 
> s/i/argc/

Right you are!

Thank you,
Dscho

> 
> >                         strbuf_addch(buf, delim);
> >                         strbuf_addstr(buf, *(++argv);
> >                 }
> >
> >                 return buf->buf;
> >         }
> 



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux