On Mon, Sep 3, 2018 at 2:44 PM Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > where `strbuf_join_argv()` would be implemented like this (and I would put > it into strbuf.c and strbuf.h: > > const char *strbuf_join_argv(struct strbuf *buf, > int argc, const char **argv, char delim) > { > if (!argc) > return buf->buf; > > strbuf_addstr(buf, *argv); > while (--i) { s/i/argc/ > strbuf_addch(buf, delim); > strbuf_addstr(buf, *(++argv); > } > > return buf->buf; > }