Hello, This a new iteration of `stash.c`. What is new? * Some commits got squashed. The commit related to replacing `git apply` child process was dropped since it wasn't the best idea. * In v7, there was a bug [1] related to config `git stash show` The bug was fixed and a test file was added for this. * Fixed `git stash [push]` [2]. In v7, `git stash -q drop` would act like `git stash push -q drop`. * Fixed coding-style nits. Verified that messages are marked for translation and are going to the correct output stream. * Fixed one memory leak (related to `strbuf_detach`). * Simplified the code a little bit. [1]: https://public-inbox.org/git/20180815210142.GN2734@xxxxxxxxxxxxxxxxxxxxxxxx/ [2]: https://public-inbox.org/git/20180818165102.GF11326@xxxxxxxxxxxxxxxxxxxxxxxx/ Best regards, Paul Joel Teichroeb (5): stash: improve option parsing test coverage stash: convert apply to builtin stash: convert drop and clear to builtin stash: convert branch to builtin stash: convert pop to builtin Paul-Sebastian Ungureanu (15): sha1-name.c: add `get_oidf()` which acts like `get_oid()` stash: update test cases conform to coding guidelines stash: rename test cases to be more descriptive stash: add tests for `git stash show` config stash: convert list to builtin stash: convert show to builtin stash: mention options in `show` synopsis. stash: convert store to builtin stash: convert create to builtin stash: convert push to builtin stash: make push -q quiet stash: convert save to builtin stash: convert `stash--helper.c` into `stash.c` stash: optimize `get_untracked_files()` and `check_changes()` stash: replace all `write-tree` child processes with API calls Documentation/git-stash.txt | 4 +- Makefile | 2 +- builtin.h | 1 + builtin/stash.c | 1563 ++++++++++++++++++++++++++++++++++ cache.h | 1 + git-stash.sh | 752 ---------------- git.c | 1 + sha1-name.c | 19 + t/t3903-stash.sh | 192 +++-- t/t3907-stash-show-config.sh | 81 ++ 10 files changed, 1795 insertions(+), 821 deletions(-) create mode 100644 builtin/stash.c delete mode 100755 git-stash.sh create mode 100755 t/t3907-stash-show-config.sh -- 2.19.0.rc0.22.gc26283d74e