Jeff,
Thanks for the feedback! Most of our users find CodeAI's fixes
useful, even if they are not exactly correct. However, we are
constantly working on improving the quality of CodeAI's fixes. The
more people who use it, the more we can improve it. We would love for
you to try the system directly by visiting mycode.ai. Its free for
open source users, and you can easily login using your GitHub account.
Also, you may attribute the allocator sizeof() issue to C0deAi.
That's the Github account used by the tool to submit pull requests.
-Ben
On Wed, Feb 14, 2018 at 1:05 PM, Jeff King <peff@xxxxxxxx> wrote:
> These two array allocations have several minor flaws:
>
> - they use bare malloc, rather than our error-checking
> xmalloc
>
> - they do a bare multiplication to determine the total
> size (which in theory can overflow, though in this case
> the sizes are all constants)
>
> - they use sizeof(type), but the type in the second one
> doesn't match the actual array (though it's "int" versus
> "unsigned int", which are guaranteed by C99 to have the
> same size)
>
> None of these are likely to be problems in practice, and
> this is just a test helper. But since people often look at
> test helpers as reference code, we should do our best to
> model the recommended techniques.
>
> Switching to ALLOC_ARRAY fixes all three.
>
> Signed-off-by: Jeff King <peff@xxxxxxxx>
> ---
> The sizeof() thing came from Code AI's original email. I'm happy to
> include a Reported-by there, but I wasn't sure of the correct entity to
> credit. :)
>
> t/helper/test-hashmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/helper/test-hashmap.c b/t/helper/test-hashmap.c
> index 1145d51671..b36886bf35 100644
> --- a/t/helper/test-hashmap.c
> +++ b/t/helper/test-hashmap.c
> @@ -85,8 +85,8 @@ static void perf_hashmap(unsigned int method, unsigned int rounds)
> unsigned int *hashes;
> unsigned int i, j;
>
> - entries = malloc(TEST_SIZE * sizeof(struct test_entry *));
> - hashes = malloc(TEST_SIZE * sizeof(int));
> + ALLOC_ARRAY(entries, TEST_SIZE);
> + ALLOC_ARRAY(hashes, TEST_SIZE);
> for (i = 0; i < TEST_SIZE; i++) {
> snprintf(buf, sizeof(buf), "%i", i);
> entries[i] = alloc_test_entry(0, buf, strlen(buf), "", 0);
> --
> 2.16.1.464.gc4bae515b7
>
--
Sincerely,
CodeAI Tech Support Team
