This series started with me fixing the sizeof() mismatch discussed in https://public-inbox.org/git/20180214164628.GA907@xxxxxxxxxxxxxxxxxxxxx/ but I found a number of minor irritations. Most of them are cosmetic in practice, but I think it's important for test-helper code like this to model best practices, since people are likely to use it as a reference. [1/6]: test-hashmap: use ALLOC_ARRAY rather than bare malloc [2/6]: test-hashmap: check allocation computation for overflow [3/6]: test-hashmap: use xsnprintf rather than snprintf [4/6]: test-hashmap: use strbuf_getline rather than fgets [5/6]: test-hashmap: simplify alloc_test_entry [6/6]: test-hashmap: use "unsigned int" for hash storage t/helper/test-hashmap.c | 53 +++++++++++++++++++++-------------------- 1 file changed, 27 insertions(+), 26 deletions(-) -Peff
