On Mon, Dec 19, 2016 at 08:53:30PM +0700, Duy Nguyen wrote:
> >> Your commit message does not make clear if you want this "fatal" to be
> >> grep-able (by scripts) or not. If not, please _() the string. Maybe
> >> this to reduce work for translators
> >>
> >> /* TRANSLATORS: this is the prefix before usage error */
> >> fprintf(stderr, "%s %s\n\n", _("fatal:"), msg);
> >
> > I don't think we translate any of our "fatal:", "error:", etc, do we?
> > It certainly doesn't look like it in usage.c.
>
> I know. But those existed before the l10n starts, some of those belong
> to plumbing messages. This one is new.
We add lots of new messages which are themselves translated, and they
still get untranslated prefixes. It seems like consistency is more
important than translating this one spot. But then, I do not use a
translated git myself, so I would not see the difference either way.
-Peff