On Thu, Dec 1, 2016 at 12:59 PM, Jeff King <peff@xxxxxxxx> wrote: > On Thu, Dec 01, 2016 at 12:54:44PM -0800, Brandon Williams wrote: > >> > I think this more robust check is probably a good idea, that way we >> > don't step into a submodule with a .git directory that isn't really a >> > .git dir. >> >> Looks like this is a no-go as well...the call to is_git_directory() ends >> up calling real_path...which ends up performing the chdir call, which >> puts us right back to where we started! (as a side note I was using >> is_git_directory else where...which I now know I can't use) > > Bleh. Looks like it happens as part of the recently-added > get_common_dir(). I'm not sure if that is ever relevant for submodules, > but I guess in theory you could have a submodule clone that is part of a > worktree? Sure we can, for a test that we don't have that, see the embedgitdirs series. ;) For now each submodule has its own complete git dir, but the vision would be to have a common git dir for submodules in the common superprojects git dir as well, such that objects are shared actually. :) > > -Peff