On Thu, Dec 01, 2016 at 01:56:32PM -0800, Stefan Beller wrote: > > Bleh. Looks like it happens as part of the recently-added > > get_common_dir(). I'm not sure if that is ever relevant for submodules, > > but I guess in theory you could have a submodule clone that is part of a > > worktree? > > Sure we can, for a test that we don't have that, see the embedgitdirs series. ;) > > For now each submodule has its own complete git dir, but the vision > would be to have a common git dir for submodules in the common > superprojects git dir as well, such that objects are shared actually. :) Fair enough. Given that it seems to behave OK even in error cases, the simple stat() test may be the best option, then. I do think we should consider adding a few test cases to make sure it continues to behave in the error cases (just because we are relying partially on what git's setup code happens to do currently, and we'd want to protect ourselves against regressions). -Peff