On Thu, Dec 01, 2016 at 01:18:35AM +0000, Ramsay Jones wrote: > >> I forgot, we ended up reversing course later and silencing them: > >> > >> http://public-inbox.org/git/20140505052117.GC6569@xxxxxxxxxxxxxxxxxxxxx/ > >> > >> By the rationale of that conversation, we should be doing: > >> > >> warning("%s", ""); > >> > >> here. > > > > I forgot too. Thanks for digging up that thread. > > Yes, I blamed wt-status.c:227 and came up with commit 7d7d68022 > as well. > > So, by the same rationale, we should remove -Wno-format-zero-length > from DEVELOPER_CFLAGS. yes? I don't have a preference on which direction we go, but yes, right now we are in an awkward middle ground. We should do one of: 1. Drop -Wno-format-zero-length from DEVELOPER_CFLAGS and make sure future patches to do not violate it. 2. Declare warning("") as OK. I still think the warning is silly, but (1) has value in that it produces the least surprise and annoyance to various people building Git. -Peff