On 30/11/16 23:46, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > >> I forgot, we ended up reversing course later and silencing them: >> >> http://public-inbox.org/git/20140505052117.GC6569@xxxxxxxxxxxxxxxxxxxxx/ >> >> By the rationale of that conversation, we should be doing: >> >> warning("%s", ""); >> >> here. > > I forgot too. Thanks for digging up that thread. Yes, I blamed wt-status.c:227 and came up with commit 7d7d68022 as well. So, by the same rationale, we should remove -Wno-format-zero-length from DEVELOPER_CFLAGS. yes? ATB, Ramsay Jones