On Wed, Nov 30, 2016 at 10:37:40PM +0000, Ramsay Jones wrote:
> > Anyway. Those are all options, but I don't think there is any problem
> > with sticking with warning("") for now. It is not the first part of the
> > code that tickles the format-zero-length warning.
>
> Hmm, well I have been building git for some time with the warning
> enabled without problem.
>
> [I can see a few examples of 'status_printf_ln(s, c, "%s", "");' in
> git-grep output, so ...]
>
> I am not suggesting any change here, and was just curious why it
> seemed to be unnecessary now (I knew it was necessary at one time).
I forgot, we ended up reversing course later and silencing them:
http://public-inbox.org/git/20140505052117.GC6569@xxxxxxxxxxxxxxxxxxxxx/
By the rationale of that conversation, we should be doing:
warning("%s", "");
here.
-Peff