Jeff King <peff@xxxxxxxx> writes: >> diff --git a/path.c b/path.c >> index fe3c4d96c6..9bfaeda207 100644 >> --- a/path.c >> +++ b/path.c >> @@ -24,7 +24,8 @@ static struct strbuf *get_pathname(void) >> STRBUF_INIT, STRBUF_INIT, STRBUF_INIT, STRBUF_INIT >> }; >> static int index; >> - struct strbuf *sb = &pathname_array[3 & ++index]; >> + struct strbuf *sb = &pathname_array[index]; >> + index = (index + 1) % ARRAY_SIZE(pathname_array); >> strbuf_reset(sb); >> return sb; > > This converts the pre-increment to a post-increment, but I don't think > it matters. Yes, I think that using the ring buffer from the beginning, not from the second element from the beginning, is conceptually cleaner ;-).