Re: [PATCH] hex: use unsigned index for ring buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] hex: use unsigned index for ring buffer
From: Jeff King <peff@xxxxxxxx>
Date: Mon, 24 Oct 2016 20:30:23 -0400
Cc: René Scharfe <l.s.r@xxxxxx>, Git List <git@xxxxxxxxxxxxxxx>
In-reply-to: <xmqq60ohtib5.fsf@gitster.mtv.corp.google.com>
References: <ebf769d4-771f-499e-c7fc-f0377d8df18e@web.de> <20161023091146.p2kmqvgwxdf77dnn@sigill.intra.peff.net> <fb816dd5-8fb9-c6a6-2ec2-9ea4dddfdb26@web.de> <20161024130015.awlmgpfzixiy6wkb@sigill.intra.peff.net> <xmqqwpgx7jn6.fsf@gitster.mtv.corp.google.com> <xmqqshrl7j42.fsf@gitster.mtv.corp.google.com> <b1f9054e-fadb-c2d3-bf95-00e88e1fb85b@web.de> <xmqq60ohtib5.fsf@gitster.mtv.corp.google.com>

On Mon, Oct 24, 2016 at 04:53:50PM -0700, Junio C Hamano wrote:

> > So how about this?  It gets rid of magic number 3 and works for array
> > size that's not a power of two.  And as a nice side effect it can't
> > trigger a signed overflow anymore.
> 
> Looks good to me.  Peff?

Any of the variants discussed in this thread is fine by me.

-Peff

Follow-Ups:
- Re: [PATCH] hex: use unsigned index for ring buffer
  - From: Junio C Hamano

References:
- [PATCH] hex: use unsigned index for ring buffer
  - From: René Scharfe
- Re: [PATCH] hex: use unsigned index for ring buffer
  - From: Jeff King
- Re: [PATCH] hex: use unsigned index for ring buffer
  - From: René Scharfe
- Re: [PATCH] hex: use unsigned index for ring buffer
  - From: Jeff King
- Re: [PATCH] hex: use unsigned index for ring buffer
  - From: Junio C Hamano
- Re: [PATCH] hex: use unsigned index for ring buffer
  - From: Junio C Hamano
- Re: [PATCH] hex: use unsigned index for ring buffer
  - From: René Scharfe
- Re: [PATCH] hex: use unsigned index for ring buffer
  - From: Junio C Hamano

Prev by Date: Re: [PATCH] hex: use unsigned index for ring buffer
Next by Date: What's cooking in git.git (Oct 2016, #06; Mon, 24)
Previous by thread: Re: [PATCH] hex: use unsigned index for ring buffer
Next by thread: Re: [PATCH] hex: use unsigned index for ring buffer
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]