Hi Junio, On Wed, 3 Aug 2016, Junio C Hamano wrote: > On Wed, Aug 3, 2016 at 4:59 AM, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > > > I disagree, however, with the suggestion to sift through your `pu` branch > > and to somehow replace local branches with the commits found there. > > To be more in line with the "e-mailed patch" workflow, I think what I should > do is to send the version I queued with fixups back to the list as follow-up. > Just like reviewers review, the maintainer reviews and queues, the original > author should be able to work in the same workflow, i.e. reading and applying > an improved version of the patch from her mailbox. You seem to assume that it isn't cumbersome for people like me to extract patches out of mails and to replace existing commits using those patches. So it probably comes as a huge surprise to you to learn that this *is* cumbersome for me. I got too used to the ease of git push, git pull with or without --rebase, and many other Git commands. Having to transmogrify code changes from commits in Git into a completely different universe: plain text patches in my mailbox, and back, losing all kinds of data in the process, is just not at all that easy. And it costs a lot of time. In short: if you start "submitting patches" back to me via mail, it does not help me. It makes things harder for me. In particular when you add your sign-off to every patch and I have to strip it. If you change your workflow, I would humbly request that you do it in a way that makes things easier on both sides, not harder. It would be a totally different matter, of course, if you used the branches I publish via my GitHub repository, added fixup! and squash! commits, published the result to a public repository and then told me to pull from there, that would make things easier. We could even introduce a reword! construct, to make the review of the suggested edits of the commit message easier. I could easily verify that my branch head agrees with the base commit of your branch, I could build proper tooling around this workflow, and it would lighten my load. I guess what I am saying is that we might just as well start using this awesome tool to work with code, that tool named "Git". Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html